Static Host Catalog #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimlambrt
requested changes
May 13, 2020
jimlambrt
previously approved these changes
May 13, 2020
jimlambrt
previously approved these changes
May 27, 2020
jimlambrt
approved these changes
May 27, 2020
jefferai
reviewed
May 27, 2020
jefferai
reviewed
May 27, 2020
jefferai
reviewed
May 27, 2020
| // static_host_catalog_id is the public_id of the owning | ||
| // static_host_catalog and must be set. | ||
| // @inject_tag: gorm:"not_null" | ||
| string static_host_catalog_id = 6; |
There was a problem hiding this comment.
I thought we were using join tables for this kind of thing rather than embedding?
There was a problem hiding this comment.
A join table is normally used only for many-to-many relationships. In this case, a host catalog can have many host sets but a host set can only belong to one host catalog. So this is the normal way to do that.
jefferai
reviewed
May 27, 2020
jefferai
reviewed
May 27, 2020
jefferai
reviewed
May 27, 2020
jefferai
reviewed
May 27, 2020
Merged
This was referenced May 29, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would appreciate early feedback from everyone!
TODO