Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add json tags to vs gateway pool display #201

Merged
merged 3 commits into from
Dec 6, 2024
Merged

Conversation

dhuckins
Copy link
Contributor

@dhuckins dhuckins commented Dec 5, 2024

πŸ› οΈ Description

adds json tags for json output
we encountered a bug expected gateway_pool and got GatewayPool

πŸ”— Additional Link

πŸ—οΈ Local Testing

πŸ‘ Checklist

  • The PR has a descriptive title.
  • Input validation updated
  • Unit tests updated
  • Documentation updated
  • Major architecture changes have a corresponding RFC
  • Tests added if applicable
  • CHANGELOG entry added or label 'pr/no-changelog' added to PR

    Run CHANGELOG_PR=<PR number> make changelog/new-entry for guidance
    in authoring a changelog entry, and commit the resulting file, which should
    have a name matching your PR number. Entries should use imperative present
    tense (e.g. Add support for...)

@dhuckins dhuckins marked this pull request as ready for review December 5, 2024 22:53
@dhuckins dhuckins requested a review from a team as a code owner December 5, 2024 22:53
ncabatoff
ncabatoff previously approved these changes Dec 5, 2024
@dhuckins dhuckins merged commit 24538d9 into main Dec 6, 2024
6 checks passed
@dhuckins dhuckins deleted the dh/vs-gateway-json-tags branch December 6, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants