Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add json tags to vs gateway pool display #201

Merged
merged 3 commits into from
Dec 6, 2024
Merged

add json tags to vs gateway pool display #201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
db1f13d
add json tags for consistency
dhuckins Dec 5, 2024
b5c06e8
changelog
dhuckins Dec 5, 2024
fa61bab
Update internal/commands/vaultsecrets/gatewaypools/displayer.go
dhuckins Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/201.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
vault-secrets: corrected json output for gateways, GatewayPool -> gateway_pool
```
8 changes: 4 additions & 4 deletions internal/commands/vaultsecrets/gatewaypools/displayer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,13 @@ import (
)

type gatewayPoolWithIntegrations struct {
GatewayPool *preview_models.Secrets20231128GatewayPool
Integrations []string
GatewayPool *preview_models.Secrets20231128GatewayPool `json:"gateway_pool"`
Integrations []string `json:"integrations,omitempty"`
}

type gatewayPoolWithOauth struct {
GatewayPool *preview_models.Secrets20231128GatewayPool
Oauth *auth.OauthConfig
GatewayPool *preview_models.Secrets20231128GatewayPool `json:"gateway_pool"`
Oauth *auth.OauthConfig `json:"oauth,omitempty"`
}

type displayer struct {
Expand Down
Loading