Allow updates to aws_msk_connector connector_configuration

[epbensimpson]

Description

In January 2025 MSK was updated to allow changes to a connector's configuration without recreating the connector.

The aws_mskconnect_connector needs updating to handle this. UpdateConnector only accepts one of capacity or connectorConfiguration per call. As such, we need to check which of these has changes and call the API separately for each change. We also need to get the new connector version in between the requests.

Relations

Closes #40914

References

• Announcement about config updates
• UpdateConnector documentation

Output from Acceptance Testing

The test should pass (verified the expected values in the console), but ran into some errors on the cleanup due to restricted delete permissions for kafka clusters and S3 buckets on my end.

❯ make testacc TESTS=TestAccKafkaConnectConnector_update PKG=kafkaconnect
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.5 test ./internal/service/kafkaconnect/... -v -count 1 -parallel 20 -run='TestAccKafkaConnectConnector_update'  -timeout 360m -vet=off
2025/03/06 15:40:15 Initializing Terraform AWS Provider...
=== RUN   TestAccKafkaConnectConnector_update
=== PAUSE TestAccKafkaConnectConnector_update
=== CONT  TestAccKafkaConnectConnector_update
    connector_test.go:122: Error running post-test destroy, there may be dangling resources: exit status 1

        Error: deleting S3 Bucket (tf-acc-test-4099055771575791490): operation error S3: DeleteBucket, https response error StatusCode: 403, RequestID: R9NKR1WS1JSP2W2E, HostID: G6fnpG9rOz/WZifQi3BT8+iVeWL6Dv67kkzKl7l/tw3Qz6Jc28mAChlOmzQbqrKgzFF98Y43tinrNRYpDEc2CQ==, api error AccessDenied: <redacted> is not authorized to perform: s3:DeleteBucket on resource: "arn:aws:s3:::tf-acc-test-4099055771575791490" with an explicit deny in an identity-based policy


        Error: deleting MSK Cluster (<redacted>): operation error Kafka: DeleteCluster, https response error StatusCode: 403, RequestID: 8fb02e2e-b131-4e70-a012-c91fa84daba3, api error AccessDeniedException: <redacted> is not authorized to perform: kafka:DeleteCluster on <redacted> with an explicit deny

--- FAIL: TestAccKafkaConnectConnector_update (2786.44s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/kafkaconnect	2791.752s
FAIL
make: *** [testacc] Error 1

[github-actions]

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

• Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
• Please see our prioritization guide for additional information on how the maintainers handle prioritization.
• Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

⚠️ We've detected the following potential issues with your pull request

Maintainer Edit Permissions:

At times, our maintainers need to make direct edits to pull requests in order to prepare it to be merged. At the time of opening this pull request, your settings do not allow maintainers to make such edits. If possible, update your settings as described in the following document. If your fork is owned by an organization that limits your ability to make this change, please let us know.

GitHub: Allowing changes to a pull request branch created from a fork

[epbensimpson]

The fork is owned by an organization, I cannot enable Allow edits from maintainers for the PR

[epbensimpson]

The lint failed due to something I didn't change (afaict), but it did bring to my attention that waitConnectorUpdated returns DescribeConnectorOutput so I can remove my additional call to DescribeConnector and use that instead.

[ewbankkit]

@epbensimpson Thanks for the contribution 🎉 👏.
I have moved your work into #41706 so that we can get it merged promptly.

[github-actions]

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

[github-actions]

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.