Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_mskconnect_connector: Allow connector_configuration to be updated in-place #41706

Merged
merged 7 commits into from
Mar 7, 2025

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Mar 6, 2025

Description

Removes ForceNew from aws_mskconnect_connector.connector_configuration.

Relations

Closes #41685.
Closes #40914.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccKafkaConnectConnector_update' PKG=kafkaconnect
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.5 test ./internal/service/kafkaconnect/... -v -count 1 -parallel 20  -run=TestAccKafkaConnectConnector_update -timeout 360m -vet=off
2025/03/06 15:42:19 Initializing Terraform AWS Provider...
=== RUN   TestAccKafkaConnectConnector_update
=== PAUSE TestAccKafkaConnectConnector_update
=== CONT  TestAccKafkaConnectConnector_update
--- PASS: TestAccKafkaConnectConnector_update (3186.85s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kafkaconnect	3192.630s

@ewbankkit ewbankkit requested a review from a team as a code owner March 6, 2025 20:43
Copy link

github-actions bot commented Mar 6, 2025

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/kafkaconnect Issues and PRs that pertain to the kafkaconnect service. size/S Managed by automation to categorize the size of a PR. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Mar 6, 2025
@ewbankkit ewbankkit merged commit 6dd9cfa into main Mar 7, 2025
46 checks passed
@ewbankkit ewbankkit deleted the f-40914 branch March 7, 2025 14:13
Copy link

github-actions bot commented Mar 7, 2025

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.91.0 milestone Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/kafkaconnect Issues and PRs that pertain to the kafkaconnect service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Amazon MSK Connect now supports updating connector configuration
3 participants