-
Notifications
You must be signed in to change notification settings - Fork 697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Rebuild monad into writer over sets #9843
Conversation
da19bf1
to
c72fbea
Compare
-> [MonitorFilePath] | ||
-> IO MonitorStateFileSet | ||
go !singlePaths !globPaths [] = | ||
return (MonitorStateFileSet (reverse singlePaths) (reverse globPaths)) | ||
return (MonitorStateFileSet singlePaths globPaths) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This worries me: reverse
implies the ordering is significant. (I know it's reversing because it uses :
to prepend paths, but that still means the original path order is considered important enough to reconstruct afterward.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this worried me a bit too. I figure this was just out of habit, but I might be wrong.
c72fbea
to
be2695f
Compare
What's the status of this one (note that #9844 depends on it)? If a design discussion would be prudent before merging one or the other PR, please don't hesitate to open an issue ticket and mark it with the |
@edmundnoble Humble ping to get your attention on this. :) |
I will just close this. I'm not sure why I thought #9844 depended on it. |
Include the following checklist in your PR:
I noticed that this seemed like a more natural way for the Rebuild monad to work. Perhaps this even saves us some file watching, I didn't look into it that deeply.