Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

synchronize source repos concurrently #9844

Closed
wants to merge 3 commits into from

Conversation

edmundnoble
Copy link
Contributor

@edmundnoble edmundnoble commented Mar 26, 2024

Synchronizes source repos concurrently with 4 repos being synchronized at once. I couldn't find a good way to make this number a flag, and so I figured that if someone wants to do that, they can do it later, because doing this concurrently is already a significant speedup for me and seems to be mostly free.

I didn't write any tests, because I figured this is guaranteed to be correct and I don't know how I'd even test it.

This PR depends on #9843 just because that PR makes it more obvious that sequenceConcurrentlyBoundedRebuild is correct. This no longer depends on #9843.

QA Notes

Ran this on a work project which has 12 git source repositories. Observed the interleaved output from git and the much faster build from clean.

  • Patches conform to the coding conventions.
  • Any changes that could be relevant to users have been recorded in the changelog.
  • The documentation has been updated, if necessary.
  • Manual QA notes have been included.
  • Tests have been added. (Ask for help if you don’t know how to write them! Ask for an exemption if tests are too complex for too little coverage!)

@ulysses4ever
Copy link
Collaborator

Is this a (partial) duplicate of #10254?

@edmundnoble
Copy link
Contributor Author

Is this a (partial) duplicate of #10254?

Oh boy, looks like it is. I can close this one then. Thanks @alt-romes for taking this to the finish line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants