Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: deployment checksum annotations (fix hasura#24) #25

Merged
merged 1 commit into from
Sep 30, 2024
Merged

fix: deployment checksum annotations (fix hasura#24) #25

merged 1 commit into from
Sep 30, 2024

Conversation

jvidal-sysadmin
Copy link
Contributor

close #24

@jvidal-sysadmin jvidal-sysadmin force-pushed the fix/deployment-checksum-annotations branch from 02bc9d8 to 187d0eb Compare September 30, 2024 08:51
@jvidal-sysadmin
Copy link
Contributor Author

I have removed the .Values.secrets.enabled from the condition. Please @hgiasac, approve the new workflow when possible.

Thanks a lot!

hgiasac
hgiasac approved these changes Sep 30, 2024
View reviewed changes
Copy link
Collaborator

@hgiasac hgiasac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for contributing

@hgiasac hgiasac merged commit c13c617 into hasura:main Sep 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hgiasac hgiasac hgiasac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove "disableAnnotationTimestamp" field in favor of automatic secret/configmap checksum annotations
2 participants
@jvidal-sysadmin @hgiasac