Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deployment checksum annotations (fix hasura#24) #25

Merged
merged 1 commit into from
Sep 30, 2024
Merged

fix: deployment checksum annotations (fix hasura#24) #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions charts/graphql-engine/templates/configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,6 @@ kind: ConfigMap
metadata:
name: {{ template "common.configMapName" $ }}
namespace: {{ template "common.namespace" $ }}
annotations:
{{- if not $.Values.disableAnnotationTimestamp }}
deployment-timestamp: "{{ date "20060102150405" now }}"
{{- end }}
data:
HASURA_GRAPHQL_ENABLE_CONSOLE: {{ coalesce .enableConsole false | quote }}
{{- range $key, $value := (coalesce .extraConfigs .additionalConfigs) }}
Expand Down
5 changes: 3 additions & 2 deletions charts/graphql-engine/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,10 @@ spec:
template:
metadata:
annotations:
{{- if not .Values.disableAnnotationTimestamp }}
deployment-timestamp: "{{ date "20060102150405" now }}"
{{- if or .Values.secret.enabled .Values.postgres.enabled }}
checksum/secret: {{ include (print $.Template.BasePath "/secrets.yaml") . | sha256sum }}
{{- end }}
checksum/configmap: {{ include (print $.Template.BasePath "/configmap.yaml") . | sha256sum }}
{{- if .Values.annotations }}
{{- toYaml .Values.annotations | nindent 8 }}
{{- end }}
Expand Down
4 changes: 0 additions & 4 deletions charts/graphql-engine/templates/secrets.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,6 @@ kind: Secret
metadata:
name: {{ template "common.secretsName" $ }}
namespace: {{ template "common.namespace" $ }}
annotations:
{{- if not $.Values.disableAnnotationTimestamp }}
deployment-timestamp: "{{ date "20060102150405" now }}"
{{- end }}
data:
{{- if coalesce .metadataDbUrl ($.Values.config).metadataOnly }}
HASURA_GRAPHQL_METADATA_DATABASE_URL: {{ include "db.url" $ | b64enc | quote }}
Expand Down
4 changes: 0 additions & 4 deletions charts/graphql-engine/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,10 +103,6 @@ serviceAccount:
##
annotations: {}

## Disable the deploy timestamp annotation to skip force rollout
##
disableAnnotationTimestamp: false

## The deployment strategy to use to replace existing pods with new ones.
## DeploymentStrategy describes how to replace existing pods with new ones.
strategy: {}
Expand Down
Loading