Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lookup for relatedPersons without gndId (rpb-120) #61

Merged
merged 3 commits into from
Dec 22, 2023

Conversation

maipet
Copy link
Contributor

@maipet maipet commented Dec 20, 2023

Adjust lookup tabels for relatedPersons
Add new example to test records

Adjust lookup tabels for relatedPersons
Add new example to test records
@fsteeg
Copy link
Member

fsteeg commented Dec 20, 2023

Result looks good, deployed to test: http://test.rppd.lobid.org/1190213958

About the TSV files:

  • How did you update gndId-to-rppdId.tsv? Just by runnging gndId-to-rppdId.tsv rppd-to-gnd-mapping.flux? We should probably add running that workflow to the scripts.
  • How did you create rppdId-with-label.tsv? We should also automate and integrate that like for the one above.

@fsteeg fsteeg assigned maipet and unassigned fsteeg Dec 20, 2023
@maipet
Copy link
Contributor Author

maipet commented Dec 21, 2023

I actually edited gndId-to-rppdId.tsv directly with a regex. I'll update the existing mapping-fix and deploy the workflow for ppdId-with-label.tsv and newest tsv as well in a new step (some records of the original export has changed, so that the tsv are not up-to-date at the moment)

@fsteeg
Copy link
Member

fsteeg commented Dec 21, 2023

OK, I updated the transformRppd.sh script for what I understand is required for the full run. I updated the input file names in rppd-to-gnd-mapping.flux and rppd-rppdId-with-label-map.flux to fit with the other workflows.

I think we should not check in manual changes like the encoding issues, since these are overwritten on the full run. (I guess they are actually errors in the incoming data and should be fixed in Allegro?).

I created the lookup tables with today's RPBEXP.zip data (see transformAndIndex.sh), transformed the test data, and checked in the result. If that looks good to you @maipet I'll do the full run on the server for a new index.

@maipet
Copy link
Contributor Author

maipet commented Dec 22, 2023

okay, sounds good and the test data I checked looks good.
To the encoding-issue: should I create a Jira ticket for pk06410 and pta0927 to fix it in Allegro?

@fsteeg
Copy link
Member

fsteeg commented Dec 22, 2023

Redeployed to test, still looks good: http://test.rppd.lobid.org/1190213958

Will deploy to production and merge.

should I create a Jira ticket for pk06410 and pta0927 to fix it in Allegro?

Yes, sounds good (though I'm not sure it's actually a data entry issue in Allegro, but that would be my suspicion since encoding is correct elsewhere).

@fsteeg fsteeg merged commit c2be33b into main Dec 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants