💻 Remove modal for make teacher as admin #5631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… admin-autosave
for more information, see https://pre-commit.ci
Closed
jpelay
requested changes
Jun 27, 2024
website/admin.py
Outdated
| @@ -173,58 +174,48 @@ def get_admin_achievements_page(self, user): | |||
| page_title=gettext("title_admin"), | |||
| ) | |||
|
|
|||
| @route("/mark-as-teacher", methods=["POST"]) | |||
| def mark_as_teacher(self): | |||
| @route("/mark-as-teacher/<username_teacher>", methods=["GET"]) | |||
There was a problem hiding this comment.
I think the problem it's happening because these calls were switched from GET to POST. And, I would prefer these calls to be POST, because we are not getting any data from the server, just modifying, which is exactly what post calls are meant for.
There was a problem hiding this comment.
I've changed it back to post!
jpelay
approved these changes
Jun 29, 2024
|
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by @Felienne : remove modal for accepting teacher requests and remove reloading the page every time