Make realsense Parametric #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vatanaksoytezer
force-pushed
the
pr-realsense_arg
branch
from
6745b68
to
b428b06
Compare
hello-binit
requested changes
Sep 28, 2021
| @@ -9,7 +9,7 @@ | |||
| <arg name="model" default="$(find stretch_gazebo)/urdf/stretch_gazebo.urdf.xacro"/> | |||
| <arg name="gpu_lidar" default="false"/> | |||
| <arg name="visualize_lidar" default="false"/> | |||
| <arg name="world" default="worlds/empty.world"/> | |||
There was a problem hiding this comment.
Did you mean to remove this argument?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Realsense can be compute power demanding so it's better we make it parametric. It will be true for now, but will be easily change-able via command line or just making it false.
Note to @hello-binit this should be backported to master