WIP: Publish wheel effort #166
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given a command, the wheels attempt to achieve it using PID controllers in the firmware. Ideally, the controller closes the error between the commanded position and the current one. But actually, this isn't always possible. For example, if the goal requires the robot to be within an obstacle, the controller will push against the obstacle, making no progress, and emitting a whining noise from the wheel motors. Another example, on carpet, the controller will find it difficult to achieve the goal exactly, due to the soft flooring. Unable to close the small error, but trying all the same, the wheel motors emit a noise. Tuning the PID parameters is no good because what works well on carpet will overshoot on hardwood, and vice versa. In this commit, we relax the controller 0.5 sec after the user stops sending velocity commands, eliminating the wheel noise. Note that this commit only address wheel noise in velocity mode and a future change will be needed to address it in position mode.
hello-binit
force-pushed
the
bugfix/priority_mode_stall
branch
from
bfc2888
to
c808968
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.