Require person_add_requests on all groups (#106) #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njaeggi
force-pushed
the
feature/108/require-person-add-requests
branch
4 times, most recently
from
0a48a26 to
bfa63e7
Compare
kronn
requested changes
Feb 21, 2025
There was a problem hiding this comment.
Wir sollten uns entscheiden, ob wir das in der DB lösen (mit der Migration alle Daten anpassen, dann aber auch beim Anlegen das Attribut setzen) oder eher im Code (in den Models überall so tun, als wäre das immer aktiv).
Ich wäre für den DB-Approach.
Das Anpassen der Partials ist in beiden Fällen eine gute Idee, um ein versehentliches Deaktivieren zu verhindern.
njaeggi
force-pushed
the
feature/108/require-person-add-requests
branch
from
bfa63e7 to
8acc80d
Compare
njaeggi
force-pushed
the
feature/108/require-person-add-requests
branch
from
8acc80d to
8508811
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.