letsencrypt: support DuckDNS DNS challenge #3152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
cla-recheck
cla-signed
and removed
cla-recheck
cla-needed
labels
agners
reviewed
Nov 22, 2023
agners
approved these changes
Nov 22, 2023
|
Tnx for reviewing @agners. Build on armhf and armv7 seems to fail on building cryptography from source. The information on https://cryptography.io/en/latest/installation/#alpine suggests that
Merging #3325 with its update to Alpine 3.18 could solve this issue? |
|
Ok, #3325 is merged now, conflicts need to be resolved now and version in confiig/CHANGELOG adjusted. |
agners
approved these changes
Nov 24, 2023
Co-authored-by: Stefan Agner <[email protected]>
This was referenced Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds DuckDNS DNS challenge support.
CNAME for custom domain "test.example.com" with DuckDNS domain "abc.duckdns.org" should be set up as follows:
Note: Alias / custom domain support for obtaining a Let's Encrypt certificate in the DuckDNS addon is broken (#2505) and devs have proposed to remove support for aliases altogether (#2662 #2964).
Proposed solution was to use the DuckDNS addon for keeping a dynamic IP up to date only and configure the Let's Encrypt addon to obtain a certificate (through a HTTP challenge or third party DNS provider that is supported by the Let's Encrypt addon).
This PR allows for DuckDNS DNS challenges including for custom domains and as such no ports need to be opened to allow a HTTP challenge and no secondary DNS provider is needed to complete the DNS challenge for custom domains.