Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

letsencrypt: support DuckDNS DNS challenge #3152

Merged
merged 7 commits into from
Nov 24, 2023
Merged

letsencrypt: support DuckDNS DNS challenge #3152

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0c82aef
Add DuckDNS
iranl Jul 27, 2023
bbb719a
Update DOCS.md
iranl Jul 27, 2023
29ee785
Update config.yaml
iranl Jul 27, 2023
7dd0ebf
Update Dockerfile
iranl Jul 27, 2023
d4cb735
Update letsencrypt/build.yaml
agners Nov 22, 2023
adce8ca
Merge branch 'master' into duckdns
iranl Nov 24, 2023
a936b62
Update letsencrypt/config.yaml
iranl Nov 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions letsencrypt/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## 4.12.10

- Add DuckDNS DNS challenge support

## 4.12.9

- Add Google Domains DNS challenge support
Expand Down
2 changes: 2 additions & 0 deletions letsencrypt/DOCS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ directadmin_password: ''
dnsimple_token: ''
dnsmadeeasy_api_key: ''
dnsmadeeasy_secret_key: ''
duckdns_token: ''
google_creds: ''
google_domains_access_token: ''
google_domains_zone: ''
Expand Down Expand Up @@ -530,6 +531,7 @@ dns-digitalocean
dns-directadmin
dns-dnsimple
dns-dnsmadeeasy
dns-duckdns
dns-gehirn
dns-google
dns-hetzner
Expand Down
2 changes: 2 additions & 0 deletions letsencrypt/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ ARG \
CERTBOT_VERSION \
CERTBOT_DNS_AZURE_VERSION \
CERTBOT_DNS_DIRECTADMIN_VERSION \
CERTBOT_DNS_DUCKDNS_VERSION \
CERTBOT_DNS_HETZNER_VERSION \
CERTBOT_DNS_GOOGLE_DOMAINS_VERSION \
CERTBOT_NETCUP_VERSION \
Expand Down Expand Up @@ -40,6 +41,7 @@ RUN \
certbot-dns-directadmin==${CERTBOT_DNS_DIRECTADMIN_VERSION} \
certbot-dns-dnsimple==${CERTBOT_VERSION} \
certbot-dns-dnsmadeeasy==${CERTBOT_VERSION} \
certbot-dns-duckdns==${CERTBOT_DNS_DUCKDNS_VERSION} \
certbot-dns-gehirn==${CERTBOT_VERSION} \
certbot-dns-google==${CERTBOT_VERSION} \
certbot-dns-google-domains==${CERTBOT_DNS_GOOGLE_DOMAINS_VERSION} \
Expand Down
1 change: 1 addition & 0 deletions letsencrypt/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ args:
CRYPTOGRAPHY_VERSION: 36.0.2
CERTBOT_DNS_AZURE_VERSION: 1.5.0
CERTBOT_DNS_DIRECTADMIN_VERSION: 0.0.24
CERTBOT_DNS_DUCKDNS_VERSION: v1.3
agners marked this conversation as resolved.
Show resolved Hide resolved
CERTBOT_DNS_HETZNER_VERSION: 1.0.5
CERTBOT_DNS_GOOGLE_DOMAINS_VERSION: 0.1.11
CERTBOT_DNS_TRANSIP_VERSION: 0.4.3
Expand Down
5 changes: 3 additions & 2 deletions letsencrypt/config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
version: 4.12.9
version: 4.12.10
slug: letsencrypt
name: Let's Encrypt
description: Manage certificate from Let's Encrypt
Expand Down Expand Up @@ -51,6 +51,7 @@ schema:
dnsimple_token: str?
dnsmadeeasy_api_key: str?
dnsmadeeasy_secret_key: str?
duckdns_token: str?
gandi_api_key: str?
gandi_sharing_id: str?
gehirn_api_secret: str?
Expand All @@ -74,7 +75,7 @@ schema:
ovh_endpoint: str?
propagation_seconds: int(60,3600)?
provider: "list(dns-azure|dns-cloudflare|dns-cloudxns|dns-digitalocean|\
dns-directadmin|dns-dnsimple|dns-dnsmadeeasy|dns-gehirn|\
dns-directadmin|dns-dnsimple|dns-dnsmadeeasy|dns-duckdns|dns-gehirn|\
dns-google|dns-google-domains|\
iranl marked this conversation as resolved.
Show resolved Hide resolved
dns-hetzner|dns-linode|dns-luadns|dns-njalla|dns-nsone|dns-ovh|\
dns-rfc2136|dns-route53|dns-sakuracloud|dns-netcup|dns-gandi|\
Expand Down
1 change: 1 addition & 0 deletions letsencrypt/rootfs/etc/cont-init.d/file-structure.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ echo -e "dns_cloudxns_api_key = $(bashio::config 'dns.cloudxns_api_key')\n" \
"dns_dnsimple_token = $(bashio::config 'dns.dnsimple_token')\n" \
"dns_dnsmadeeasy_api_key = $(bashio::config 'dns.dnsmadeeasy_api_key')\n" \
"dns_dnsmadeeasy_secret_key = $(bashio::config 'dns.dnsmadeeasy_secret_key')\n" \
"dns_duckdns_token = $(bashio::config 'dns.duckdns_token')\n" \
"dns_gehirn_api_token = $(bashio::config 'dns.gehirn_api_token')\n" \
"dns_gehirn_api_secret = $(bashio::config 'dns.gehirn_api_secret')\n" \
"dns_hetzner_api_token = $(bashio::config 'dns.hetzner_api_token')\n" \
Expand Down
5 changes: 5 additions & 0 deletions letsencrypt/rootfs/etc/services.d/lets-encrypt/run
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,11 @@ elif [ "${CHALLENGE}" == "dns" ] && [ "${DNS_PROVIDER}" == "dns-directadmin" ];
bashio::config.require 'dns.directadmin_password'
PROVIDER_ARGUMENTS+=("--authenticator" "certbot-dns-directadmin:directadmin" "--certbot-dns-directadmin:directadmin-credentials" /data/dnsapikey "--certbot-dns-directadmin:directadmin-propagation-seconds" "${PROPAGATION_SECONDS}")

#DuckDNS
elif [ "${CHALLENGE}" == "dns" ] && [ "${DNS_PROVIDER}" == "dns-duckdns" ]; then
bashio::config.require 'dns.duckdns_token'
PROVIDER_ARGUMENTS+=("--authenticator" "${DNS_PROVIDER}" "--${DNS_PROVIDER}-credentials" "/data/dnsapikey" "--${DNS_PROVIDER}-propagation-seconds" "${PROPAGATION_SECONDS}")

# Gandi
elif [ "${DNS_PROVIDER}" == "dns-gandi" ]; then
if bashio::config.exists 'dns.gandi_sharing_id'; then
Expand Down