Add Picnic shopping cart as Todo list #102855
Conversation
|
Hey there @corneyl, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
|
As reference; 
|
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
| def todo_items(self) -> list[TodoItem] | None: | ||
| """Get the current set of items in cart items.""" | ||
| if self.coordinator.data is None: | ||
| return None |
There was a problem hiding this comment.
Please note that none of the To-do have this one covered.
allenporter
added
the
noteworthy
Co-authored-by: Allen Porter <[email protected]>
|
@edenhaus Can you take a quick look at this again? |
|
Thanks! Screenshot is updated! -- Follow-up is also updated and ready for review, this allows adding items in the same way as the existing service by Picnic → #102862 |
| async_add_entities([PicnicCart(picnic_coordinator, config_entry)]) | ||
|
|
||
|
|
||
| class PicnicCart(TodoListEntity, CoordinatorEntity): |
There was a problem hiding this comment.
Please invert the inheritance order.
There was a problem hiding this comment.
Also add a type annotation to the generic CoordinatorEntity what coordinator type it holds.
| TodoItem( | ||
| summary=f"{article['name']} ({article['unit_quantity']})", | ||
| uid=f"{item['id']}-{article['id']}", | ||
| status=TodoItemStatus.NEEDS_ACTION, # We set 'NEEDS_ACTION' so they count as state |
There was a problem hiding this comment.
Please move the comment above the line to decrease the line length.
Proposed change
Add new Todo entity for Picnic.
The new todo list is a bit limited for the needs, but you can get a nice overview of what is in your cart.
Limitations
.UPDATE_TODO_ITEMis not enabledType of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: