Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow individual item deletion in To-do list #18464

Merged
merged 4 commits into from
Oct 30, 2023

Conversation

DCSBL
Copy link
Contributor

@DCSBL DCSBL commented Oct 29, 2023

Proposed change

Allow deleting individual items when .DELETE_TODO_ITEM is set.

For the normal to-do list this is a nice to have, but for lists where .UPDATE_TODO_ITEM is not set you can't delete items at all. (Checkbox is hidden, so no delete-all option). This is required for the Picnic shopping cart (home-assistant/core#102855)

Screenshot 2023-10-29 at 12 24 08 Screenshot 2023-10-29 at 12 26 24

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten
Copy link
Member

Can we only show this option when UPDATE_TODO_ITEM is not available? It gets very crowded in the UI with all the elements

@DCSBL
Copy link
Contributor Author

DCSBL commented Oct 30, 2023

Screenshot 2023-10-30 at 15 02 12 Screenshot 2023-10-30 at 14 53 02

Sure! Added that in latest commit.
I am sure people want to delete items individually even when they can edit them. So maybe adding something else to allow this while still keeping it clean. But I am not a designer 🤷‍♂️

@bramkragten
Copy link
Member

I am sure people want to delete items individually even when they can edit them. So maybe adding something else to allow this while still keeping it clean. But I am not a designer 🤷‍♂️

Yes, we will have to come up with a good UX for that 👍

@bramkragten bramkragten enabled auto-merge (squash) October 30, 2023 14:11
@bramkragten bramkragten merged commit abb5aa3 into home-assistant:dev Oct 30, 2023
8 checks passed
@DCSBL DCSBL deleted the dcsbl-todo-delete-item branch October 30, 2023 14:27
@DCSBL
Copy link
Contributor Author

DCSBL commented Oct 30, 2023

Nice thanks for merging! Ended hacktoberfest with my first PR into frontend ✅

@github-actions github-actions bot locked and limited conversation to collaborators Oct 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants