Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mode selector to Twinkly #134041

Merged
merged 10 commits into from
Jan 2, 2025

Conversation

sVnsation
Copy link
Contributor

@sVnsation sVnsation commented Dec 26, 2024

Proposed change

Added a mode selector to the Twinkly integration that allows controlling the device mode through a select entity.

  • color
  • demo
  • effect
  • movie
  • off
  • playlist
  • rt

The implementation:

  • Uses TwinklyCoordinator for state management
  • Adds a new select entity for mode control

Just like suggested from @frenck in this #83023 (comment)

{0E43FE0B-EE79-439D-91A6-CA04E050E7F6}

Type of change

  • New feature (which adds functionality to an existing integration)

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @dr1rrb, @RobBie1221, @Olen, mind taking a look at this pull request as it has been labeled with an integration (twinkly) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of twinkly can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign twinkly Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

homeassistant/components/twinkly/select.py Outdated Show resolved Hide resolved
@sVnsation sVnsation requested a review from dcmeglio December 31, 2024 17:13
@abmantis abmantis changed the title add twinkly select mode Add mode selector to Twinkly Dec 31, 2024
@home-assistant home-assistant bot marked this pull request as draft December 31, 2024 18:13
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@sVnsation sVnsation marked this pull request as ready for review January 1, 2025 13:21
Copy link
Contributor

@abmantis abmantis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@abmantis abmantis merged commit 0b32342 into home-assistant:dev Jan 2, 2025
34 checks passed
@sVnsation sVnsation deleted the sVnsation-twinkly_select_mode branch January 2, 2025 11:24
@github-actions github-actions bot locked and limited conversation to collaborators Jan 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Twinkly integration disabling playlist on state change
3 participants