Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement base entity class for Twinkly #134382

Merged
merged 3 commits into from
Jan 1, 2025

Conversation

sVnsation
Copy link
Contributor

@sVnsation sVnsation commented Jan 1, 2025

Proposed change

Like suggested from @abmantis here #134041 (comment)
The implementation creates a new base entity class to eliminate code duplication for future additions. This base class will handle the common DeviceInfo instantiation and provide shared functionality. Useful for implementing additional Entity Types.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Jan 1, 2025

Hey there @dr1rrb, @RobBie1221, @Olen, mind taking a look at this pull request as it has been labeled with an integration (twinkly) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of twinkly can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign twinkly Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@sVnsation sVnsation requested a review from joostlek January 1, 2025 12:37
@joostlek joostlek merged commit 55dc4b0 into home-assistant:dev Jan 1, 2025
34 checks passed
@sVnsation sVnsation deleted the twinkly_base_entity branch January 1, 2025 13:19
@github-actions github-actions bot locked and limited conversation to collaborators Jan 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants