-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frontend: deprecate extra_html_url
#37843
Merged
Merged
+24
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-home-assistant
bot
added
breaking-change
core
integration: frontend
small-pr
PRs with less than 30 lines.
labels
Jul 14, 2020
Hey there @home-assistant/frontend, mind taking a look at this pull request as its been labeled with an integration ( |
frenck
reviewed
Jul 14, 2020
@@ -85,6 +85,8 @@ | |||
CONFIG_SCHEMA = vol.Schema( | |||
{ | |||
DOMAIN: vol.Schema( | |||
cv.deprecated(CONF_EXTRA_HTML_URL, invalidation_version="0.115"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have to wrap it like so:
CONFIG_SCHEMA = vol.Schema(
{
DOMAIN: vol.All(
cv.deprecated(CONF_EXTRA_HTML_URL, invalidation_version="0.115"),
cv.deprecated(CONF_EXTRA_HTML_URL_ES5, invalidation_version="0.115"),
vol.Schema(
{
vol.Optional(CONF_FRONTEND_REPO): cv.isdir,
vol.Optional(CONF_THEMES): vol.Schema(
{cv.string: {cv.string: cv.string}}
),
vol.Optional(CONF_EXTRA_HTML_URL): vol.All(cv.ensure_list, [cv.string]),
vol.Optional(CONF_EXTRA_MODULE_URL): vol.All(
cv.ensure_list, [cv.string]
),
vol.Optional(CONF_EXTRA_JS_URL_ES5): vol.All(
cv.ensure_list, [cv.string]
),
# We no longer use these options.
vol.Optional(CONF_EXTRA_HTML_URL_ES5): cv.match_all,
vol.Optional(CONF_JS_VERSION): cv.match_all,
},
)
)
},
extra=vol.ALLOW_EXTRA,
)
8 tasks
balloob
approved these changes
Jul 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
We used to allow the user to specify HTML files via
extra_html_url
that we would import into the page. When it became clear that HTML imports were not going to make it, we replaced that withextra_module_url
andextra_js_url_es5
(#24675 by @thomasloven, June 21, 2019).HTML imports are no longer supported by any browser, and we have to polyfill it to make it work, this is expensive.
extra_html_url
is now deprecated and support will be removed in 0.115. You can switch to the newextra_module_url
orextra_js_url_es5
by changing your imported file to JavaScript.Proposed change
home-assistant/frontend#6028
Type of change
Example entry for
configuration.yaml
:# Example configuration.yaml
Additional information
extra_module_url
in frontend home-assistant.io#13997Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale: