Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate extra_module_url in frontend #13997

Merged
merged 2 commits into from
Jul 14, 2020
Merged

Deprecate extra_module_url in frontend #13997

merged 2 commits into from
Jul 14, 2020

Conversation

bramkragten
Copy link
Member

Proposed change

Deprecate extra_module_url in the frontend

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant bot added has-parent This PR has a parent PR in a other repo in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Jul 14, 2020
@probot-home-assistant probot-home-assistant bot added the current This PR goes into the current branch label Jul 14, 2020
@bramkragten bramkragten mentioned this pull request Jul 14, 2020
Merged
20 tasks
frenck
frenck previously approved these changes Jul 14, 2020
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck changed the base branch from current to next July 14, 2020 17:04
@frenck frenck dismissed their stale review July 14, 2020 17:04

The base branch was changed.

@frenck frenck added next This PR goes into the next branch and removed current This PR goes into the current branch labels Jul 14, 2020
@frenck frenck self-requested a review July 14, 2020 17:05
@frenck frenck force-pushed the deprecate-extra_module_url branch from 10976f1 to d209f4c Compare July 14, 2020 17:06
frenck
frenck previously approved these changes Jul 14, 2020
View reviewed changes
@frenck frenck added awaits-parent Awaits the merge of an parent PR and removed in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Jul 14, 2020
@bramkragten bramkragten merged commit 3e7233c into next Jul 14, 2020
@probot-home-assistant probot-home-assistant bot removed the awaits-parent Awaits the merge of an parent PR label Jul 14, 2020
@bramkragten bramkragten deleted the deprecate-extra_module_url branch July 14, 2020 19:06
zsarnett pushed a commit to zsarnett/home-assistant.io that referenced this pull request Jul 15, 2020
@bramkragten @zsarnett
Deprecate extra_module_url in frontend (home-assistant#13997)
b6a24d8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frenck frenck frenck approved these changes

Assignees
No one assigned
Labels
has-parent This PR has a parent PR in a other repo next This PR goes into the next branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bramkragten @frenck