-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PECO smart meter binary_sensor #71034
Conversation
59249a9
to
c52b5c4
Compare
It would seem to me the user gets one or the other. Why not adding both |
It is simpler for users because the meter check takes a while. Users can always go to the config flow again to add a outage counter or another smart meter. |
64fd607
to
6549954
Compare
6549954
to
911d9d3
Compare
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
Not stale.. |
d5ed986
to
4f9bf60
Compare
Setting as draft until conflicts resolved |
ceed38c
to
afdcb98
Compare
1189ace
to
d2dae85
Compare
ddd3296
to
3cb8305
Compare
@IceBotYT to be clear, this PR won't be merged with the sleep hiding a problem with the progress. If you can't work it out yourself, please contact me on Discord and we can solve it together. |
PECO needs updates to the branding (for a separate PR though):
|
This reverts commit 36ca908.
72457cd
to
7eaa7f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks @IceBotYT 👍
Temporarily reverted by #105222 |
Proposed change
Add support for smart meter functionality, which verifies if your meter is receiving power or not.
This is the same implementation as the website here
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: