Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race condition with Data Entry Flow Progress #18775

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

bramkragten
Copy link
Member

@bramkragten bramkragten commented Nov 27, 2023

Proposed change

If the progress was done before we subscribed to it, we would miss it.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Copy link
Collaborator

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with core PR home-assistant/core#71034 👍

@bramkragten bramkragten merged commit 22e86af into dev Nov 27, 2023
13 checks passed
@bramkragten bramkragten deleted the race-DataEntryFlowProgress branch November 27, 2023 10:28
bramkragten added a commit that referenced this pull request Dec 7, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants