Subscribe to the issue registry as early as possible #18384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We always subscribe here so we should do it as soon as possible to reduce reconnect latency
bramkragten
approved these changes
Oct 24, 2023
|
Thanks |
bdraco
added a commit
that referenced
this pull request
Oct 25, 2023
These are always called late when loading the UI which means another round trip to fetch them. Since we know we are going to fetch them anyways, add them as preloads. The recorder prefetch makes quite a difference outside the local network since the whole UI blocks to wait for it to come back. follow up to #18384 and #18332
9 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
We always subscribe here so we should do it as soon as possible to reduce reconnect latency
There are still a few other things we fetch nearly every time that are not accounted for (these are harder to prefetch):
getRecorderInfogetEnergyPreferencessubscribeLovelaceUpdatestitletranslationssubscribeNotificationsType of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: