Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serial number to the device info card #18386

Merged
merged 5 commits into from
Oct 25, 2023

Conversation

jpbede
Copy link
Member

@jpbede jpbede commented Oct 24, 2023

Proposed change

Add the newly introduced serial number from the core (home-assistant/core#102334) to the device info card.

CleanShot 2023-10-24 at 21 15 28@2x

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@github-actions github-actions bot added the Design Related to Home Assistant design gallery label Oct 24, 2023
@bdraco
Copy link
Member

bdraco commented Oct 24, 2023

Doesn't need to be in this PR, but would also be nice to include the MAC address as its sometimes more useful for the user to identify/locate the device home-assistant/core#102334 (comment)

bramkragten
bramkragten previously approved these changes Oct 24, 2023
frenck
frenck previously approved these changes Oct 25, 2023
@frenck frenck merged commit 7ce7cbb into home-assistant:dev Oct 25, 2023
8 checks passed
@frenck
Copy link
Member

frenck commented Oct 25, 2023

Thanks, @jpbede 👍

../Frenck

@jpbede jpbede deleted the serial-number-device-info branch October 25, 2023 05:45
@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed Design Related to Home Assistant design gallery hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants