-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add serial number to the device info card #18386
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpbede
force-pushed
the
serial-number-device-info
branch
from
October 24, 2023 19:35
18e1726
to
df94011
Compare
Doesn't need to be in this PR, but would also be nice to include the MAC address as its sometimes more useful for the user to identify/locate the device home-assistant/core#102334 (comment) |
bramkragten
reviewed
Oct 24, 2023
bramkragten
previously approved these changes
Oct 24, 2023
Co-authored-by: Bram Kragten <[email protected]>
frenck
previously approved these changes
Oct 25, 2023
frenck
approved these changes
Oct 25, 2023
Thanks, @jpbede 👍 ../Frenck |
9 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Add the newly introduced serial number from the core (home-assistant/core#102334) to the device info card.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: