Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert fetching config flow after subscribe for progress #18939

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

bramkragten
Copy link
Member

Reverts #18775

Breaking change

The original PR was created for home-assistant/core#71034, that will have a timing issue again.

Proposed change

This change, while technically probably correct, causes issues with flows, we are going to revert this for now, check all the config flows and fix them, and afterwards re-enable this.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@frenck frenck merged commit 76d3c6e into dev Dec 7, 2023
14 checks passed
@frenck frenck deleted the revert-fetch-after-subscribe branch December 7, 2023 08:31
@frenck frenck added this to the 2023.12 milestone Dec 7, 2023
@emontnemery
Copy link
Collaborator

I don't agree with this PR.

#18775 fixed a fundamental flaw in the show progress functionality.
It should always be possible to refetch a flow. If it isn't, that's a bug in the flow where it incorrectly does not track its state.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants