Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preview for time_date integration #19249

Closed
wants to merge 1 commit into from
Closed

Conversation

emontnemery
Copy link
Collaborator

@emontnemery emontnemery commented Jan 2, 2024

Proposed change

Add preview for time_date integration

Core PR: home-assistant/core#104183

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

this.stepData,
this._setPreview
);
} catch (err) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
} catch (err) {
await this._unsub;
} catch (err) {

@gjohansson-ST gjohansson-ST mentioned this pull request Jan 19, 2024
9 tasks
@emontnemery
Copy link
Collaborator Author

emontnemery commented Jan 22, 2024

Replaced by PR #19476

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants