Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fixed colors for qr codes #19723

Closed
wants to merge 4 commits into from
Closed

Use fixed colors for qr codes #19723

wants to merge 4 commits into from

Conversation

thomasloven
Copy link
Contributor

@thomasloven thomasloven commented Feb 8, 2024

Breaking change

Proposed change

Use a fixed black and white color qr code instead of the user theme.

Fixes #19722, hopefully.

The qrcode canvas requires colors to be specified as rgba hex codes (ex #000000ff, #ffffffff for black and white), but the css specification used for themes allows for a lot of other things like magenta, rgb(255, 0, 0), rgba(1, 2, 3, 4) etc.

A black-on-white qr code is likely more reliable anyway.

This problem was introduced in #19155
Documentation reference: https://www.npmjs.com/package/qrcode#colordark

I HAVE NOT TESTED THIS. PLEASE DO BEFORE MERGING

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@piitaya piitaya mentioned this pull request Feb 8, 2024
9 tasks
@piitaya
Copy link
Member

piitaya commented Feb 8, 2024

Thanks @thomasloven ! I open the same PR with theme color support to avoid white background on dark themes.

@bramkragten bramkragten closed this Feb 8, 2024
@frenck
Copy link
Member

frenck commented Feb 8, 2024

Replaced by #19726

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tuya integration fails
4 participants