Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Use a fixed black and white color qr code instead of the user theme.
Fixes #19722, hopefully.
The qrcode canvas requires colors to be specified as rgba hex codes (ex
#000000ff
,#ffffffff
for black and white), but the css specification used for themes allows for a lot of other things likemagenta
,rgb(255, 0, 0)
,rgba(1, 2, 3, 4)
etc.A black-on-white qr code is likely more reliable anyway.
This problem was introduced in #19155
Documentation reference: https://www.npmjs.com/package/qrcode#colordark
I HAVE NOT TESTED THIS. PLEASE DO BEFORE MERGING
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: