Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rgb theme variables for qrcode #19726

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Use rgb theme variables for qrcode #19726

merged 1 commit into from
Feb 8, 2024

Conversation

piitaya
Copy link
Member

@piitaya piitaya commented Feb 8, 2024

Proposed change

Same as #19723 but with theme color support so it works well on dark mode.

Fixes #19722

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@piitaya piitaya added this to the 2024.2 milestone Feb 8, 2024
@bramkragten bramkragten merged commit b1e1b44 into dev Feb 8, 2024
14 checks passed
@bramkragten bramkragten deleted the fix-qr-colors-themes branch February 8, 2024 11:04
@frenck frenck mentioned this pull request Feb 8, 2024
9 tasks
bramkragten pushed a commit that referenced this pull request Feb 8, 2024
bramkragten pushed a commit that referenced this pull request Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tuya integration fails
2 participants