Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lock commands feature to tile card #19880

Closed
wants to merge 14 commits into from

Conversation

marcgeurts
Copy link
Contributor

@marcgeurts marcgeurts commented Feb 26, 2024

Proposed change

Added lock-commands feature for the tile card inspired from the mushroom lock card from @piitaya

https://github.com/piitaya/lovelace-mushroom/blob/main/docs/cards/lock.md

image image

image image

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

type: tile
entity: lock.front_door
features:
  - type: lock-commands

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@github-actions github-actions bot added the Design Related to Home Assistant design gallery label Feb 26, 2024
@marcgeurts marcgeurts marked this pull request as draft February 26, 2024 14:36
@marcgeurts marcgeurts marked this pull request as ready for review February 26, 2024 14:36
@matthiasdebaat
Copy link
Collaborator

Thanks @marcgeurts for adding this feature! I wanted to share some feedback based on things we learned through some design iterations for an improved more-info dialog.

  • The door can swing open when unlatching/opening a door. To ensure that a user does not accidentally do this, we recommend the following:
    • Show an Open door label instead of the icon, because the icon can be interpreted differently.
    • Add confirmation, with a double tap as our design concept. We started with a confirmation dialogue, but this interrupted the flow too much.
  • Opening a door is a different action than locking and unlocking it. To make this distinction, they must not be in the same proximity. For lock I would suggest to create two features:

@marcgeurts marcgeurts closed this Apr 17, 2024
@marcgeurts marcgeurts deleted the lock-commands branch April 17, 2024 12:15
@silamon silamon mentioned this pull request Apr 17, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed Design Related to Home Assistant design gallery Tile card
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants