Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Decorquip Dream as supported brand #36616

Draft
wants to merge 3 commits into
base: current
Choose a base branch
from

Conversation

starkillerOG
Copy link
Contributor

@starkillerOG starkillerOG commented Dec 30, 2024

Proposed change

Add Decorquip Dream as supported brand, reported to work here: #36461

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Summary by CodeRabbit

  • Documentation
    • Added documentation for new compatible brands:
      • Decorquip Dream
      • Dreamhub Pro 191726
      • Dreamhub mini 191717
    • Updated supported bridges information for Motionblinds integration

@home-assistant home-assistant bot added the current This PR goes into the current branch label Dec 30, 2024
Copy link

netlify bot commented Dec 30, 2024

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit c4746e1
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/677585d524b04800089db0e9
😎 Deploy Preview https://deploy-preview-36616--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@home-assistant
Copy link

It seems that this PR is targeted against an incorrect branch since it has a parent PR on one of our codebases. Documentation that needs to be updated for an upcoming release should target the next branch. Please change the target branch of this PR to next and rebase if needed.

@home-assistant home-assistant bot added in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Dec 30, 2024
@starkillerOG starkillerOG removed in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Dec 30, 2024
Copy link
Contributor

coderabbitai bot commented Dec 30, 2024

📝 Walkthrough

Walkthrough

The pull request updates the documentation for the Motionblinds integration in Home Assistant, expanding the list of compatible brands and devices. The changes specifically add two new brands: "Decorquip Dream" and "Dreamhub", including two Dreamhub models (Pro 191726 and mini 191717). These additions provide users with more information about the integration's hardware compatibility and supported devices.

Changes

File Changes
source/_integrations/motion_blinds.markdown - Added Decorquip Dream brand
- Added Dreamhub Pro 191726 bridge
- Added Dreamhub mini 191717 bridge

Sequence Diagram

sequenceDiagram
    participant User
    participant HomeAssistant
    participant MotionBlindsBridge
    participant Blinds

    User->>HomeAssistant: Configure integration
    HomeAssistant->>MotionBlindsBridge: Connect to bridge
    MotionBlindsBridge->>Blinds: Discover compatible devices
    Blinds-->>MotionBlindsBridge: Return device information
    MotionBlindsBridge-->>HomeAssistant: Report supported devices
    HomeAssistant-->>User: Display available blind controls
Loading

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6218079 and 1dcfe79.

📒 Files selected for processing (1)
  • source/_integrations/motion_blinds.markdown (2 hunks)
🔇 Additional comments (1)
source/_integrations/motion_blinds.markdown (1)

30-30: Please verify the Decorquip Dream URL

The URL format (post.php?dream) seems unusual compared to other brand URLs in the list. Could you please:

  1. Verify if there's a more stable product page URL available
  2. Confirm that this URL will remain accessible long-term

Comment on lines +69 to +70
- Dreamhub Pro 191726
- Dreamhub mini 191717
Copy link
Contributor

@coderabbitai coderabbitai bot Dec 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Documentation needed for Dreamhub setup

The Dreamhub bridges have been added to the supported list, but there are no instructions for retrieving the API key from the Dreamhub app. Other brands in the list (Motionblinds, Brel Home, Bloc Blinds, etc.) have specific sections detailing this process.

Could you please add a section under "Retrieving the API Key" with instructions for Dreamhub users?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressive AI, but I don't have such instructions....
Will most likely be very simular to other brands.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@starkillerOG Thank you for clarifying! Since you don’t currently have specific instructions for the Dreamhub app, we could either:

  1. Add a placeholder paragraph that states the retrieval process for Dreamhub keys is generally similar to the existing instructions for other brands (e.g., tapping multiple times on an “About” page).
  2. If you would like, we can open a new follow-up issue to gather or document the correct steps once more knowledgeable users or the vendor themselves provide details.

Let me know what approach you prefer!

@@ -27,6 +27,7 @@ Additionally the following brands have been reported to also work with this inte
- [Bloc Blinds](https://www.blocblinds.com/)
- [Brel Home](https://www.brel-home.nl/)
- [3 Day Blinds](https://www.3dayblinds.com/)
- [Decorquip Dream](https://www.decorquip.com/post.php?dream)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The others are all virtual integrations, why isn't this one added as such?

../Frenck

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be perfectly honest: because I was lazy and mostly hate to get the correct brand images.

I will add it as a virtual integration and also check the list if I missed a few more.

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft December 31, 2024 21:35
@home-assistant home-assistant bot added has-parent This PR has a parent PR in a other repo in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Jan 1, 2025
@home-assistant
Copy link

home-assistant bot commented Jan 1, 2025

It seems that this PR is targeted against an incorrect branch since it has a parent PR on one of our codebases. Documentation that needs to be updated for an upcoming release should target the next branch. Please change the target branch of this PR to next and rebase if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
current This PR goes into the current branch has-parent This PR has a parent PR in a other repo in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants