-
-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Decorquip Dream as supported brand #36616
base: current
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
It seems that this PR is targeted against an incorrect branch since it has a parent PR on one of our codebases. Documentation that needs to be updated for an upcoming release should target the |
📝 WalkthroughWalkthroughThe pull request updates the documentation for the Motionblinds integration in Home Assistant, expanding the list of compatible brands and devices. The changes specifically add two new brands: "Decorquip Dream" and "Dreamhub", including two Dreamhub models (Pro 191726 and mini 191717). These additions provide users with more information about the integration's hardware compatibility and supported devices. Changes
Sequence DiagramsequenceDiagram
participant User
participant HomeAssistant
participant MotionBlindsBridge
participant Blinds
User->>HomeAssistant: Configure integration
HomeAssistant->>MotionBlindsBridge: Connect to bridge
MotionBlindsBridge->>Blinds: Discover compatible devices
Blinds-->>MotionBlindsBridge: Return device information
MotionBlindsBridge-->>HomeAssistant: Report supported devices
HomeAssistant-->>User: Display available blind controls
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/motion_blinds.markdown
(2 hunks)
🔇 Additional comments (1)
source/_integrations/motion_blinds.markdown (1)
30-30
: Please verify the Decorquip Dream URL
The URL format (post.php?dream
) seems unusual compared to other brand URLs in the list. Could you please:
- Verify if there's a more stable product page URL available
- Confirm that this URL will remain accessible long-term
- Dreamhub Pro 191726 | ||
- Dreamhub mini 191717 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Documentation needed for Dreamhub setup
The Dreamhub bridges have been added to the supported list, but there are no instructions for retrieving the API key from the Dreamhub app. Other brands in the list (Motionblinds, Brel Home, Bloc Blinds, etc.) have specific sections detailing this process.
Could you please add a section under "Retrieving the API Key" with instructions for Dreamhub users?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Impressive AI, but I don't have such instructions....
Will most likely be very simular to other brands.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@starkillerOG Thank you for clarifying! Since you don’t currently have specific instructions for the Dreamhub app, we could either:
- Add a placeholder paragraph that states the retrieval process for Dreamhub keys is generally similar to the existing instructions for other brands (e.g., tapping multiple times on an “About” page).
- If you would like, we can open a new follow-up issue to gather or document the correct steps once more knowledgeable users or the vendor themselves provide details.
Let me know what approach you prefer!
@@ -27,6 +27,7 @@ Additionally the following brands have been reported to also work with this inte | |||
- [Bloc Blinds](https://www.blocblinds.com/) | |||
- [Brel Home](https://www.brel-home.nl/) | |||
- [3 Day Blinds](https://www.3dayblinds.com/) | |||
- [Decorquip Dream](https://www.decorquip.com/post.php?dream) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The others are all virtual integrations, why isn't this one added as such?
../Frenck
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be perfectly honest: because I was lazy and mostly hate to get the correct brand images.
I will add it as a virtual integration and also check the list if I missed a few more.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
It seems that this PR is targeted against an incorrect branch since it has a parent PR on one of our codebases. Documentation that needs to be updated for an upcoming release should target the |
Proposed change
Add Decorquip Dream as supported brand, reported to work here: #36461
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit