Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Decorquip Dream as supported brand #36616

Draft
wants to merge 3 commits into
base: current
Choose a base branch
from
Draft
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions source/_integrations/motion_blinds.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ Additionally the following brands have been reported to also work with this inte
- [Bloc Blinds](https://www.blocblinds.com/)
- [Brel Home](https://www.brel-home.nl/)
- [3 Day Blinds](https://www.3dayblinds.com/)
- [Decorquip Dream](https://www.decorquip.com/post.php?dream)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The others are all virtual integrations, why isn't this one added as such?

../Frenck

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be perfectly honest: because I was lazy and mostly hate to get the correct brand images.

I will add it as a virtual integration and also check the list if I missed a few more.

- [Diaz](https://www.diaz.be/en/)
- [Dooya](http://www.dooya.com/)
- [Gaviota](https://www.gaviotagroup.com/en/)
Expand Down Expand Up @@ -65,6 +66,8 @@ The following bridges are reported to work with this integration:
- SIRO Connect SI7005
- Heicko Smart Stick 1ST
- DD7006A Smart Home bridge
- Dreamhub Pro 191726
- Dreamhub mini 191717
Comment on lines +69 to +70
Copy link
Contributor

@coderabbitai coderabbitai bot Dec 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Documentation needed for Dreamhub setup

The Dreamhub bridges have been added to the supported list, but there are no instructions for retrieving the API key from the Dreamhub app. Other brands in the list (Motionblinds, Brel Home, Bloc Blinds, etc.) have specific sections detailing this process.

Could you please add a section under "Retrieving the API Key" with instructions for Dreamhub users?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressive AI, but I don't have such instructions....
Will most likely be very simular to other brands.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@starkillerOG Thank you for clarifying! Since you don’t currently have specific instructions for the Dreamhub app, we could either:

  1. Add a placeholder paragraph that states the retrieval process for Dreamhub keys is generally similar to the existing instructions for other brands (e.g., tapping multiple times on an “About” page).
  2. If you would like, we can open a new follow-up issue to gather or document the correct steps once more knowledgeable users or the vendor themselves provide details.

Let me know what approach you prefer!


{% include integrations/config_flow.md %}

Expand Down
Loading