Skip to content

Commit

Permalink
ci: fix generate release config
Browse files Browse the repository at this point in the history
  • Loading branch information
fredleger committed Jan 14, 2025
1 parent 969ed1d commit c43ab4f
Show file tree
Hide file tree
Showing 6 changed files with 27 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/release-config.template.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,4 @@ include-paths:
- images/{{image}}/*
- .github/actions/should-build-image/*
- .github/workflows/__shared-ci.yml
- .github/workflows/__shared-get-available-images-matrix.yml
- .github/workflows/__shared-get-available-images-matrix.yml
9 changes: 9 additions & 0 deletions .github/workflows/__shared-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,15 @@ on:
description: "Password or GitHub token (packages:read and packages:write scopes) used to log against the OCI registry."
required: true

permissions:
contents: read
issues: read
packages: write
pull-requests: read
statuses: write
# FIXME: This is a workaround for having workflow actions. See https://github.com/orgs/community/discussions/38659
id-token: write

jobs:
checks:
# FIXME: the new version of the linter fails with a lot of errors if upgraded
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/generate-release-config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
- uses: actions/upload-artifact@v4
with:
name: changed-files
name: changed-files-${{ matrix.image }}
path: ./.github/release-config/${{ matrix.image }}-release-config.yml

publish-actions-readme:
Expand All @@ -48,7 +48,8 @@ jobs:

- uses: actions/download-artifact@v4
with:
name: changed-files
pattern: changed-files-*
merge-multiple: true
path: ./.github/release-config/

- uses: tibdex/github-app-token@v1
Expand Down
13 changes: 12 additions & 1 deletion .github/workflows/pull-request-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,17 @@ on:
pull_request:
branches: [main]

# jscpd:ignore-start
permissions:
contents: read
issues: read
packages: write
pull-requests: read
statuses: write
# FIXME: This is a workaround for having workflow actions. See https://github.com/orgs/community/discussions/38659
id-token: write
# jscpd:ignore-end

jobs:
ci:
name: Continuous Integration
Expand Down Expand Up @@ -51,7 +62,7 @@ jobs:
core.setOutput('comment-body','No images have been built.');
}
- uses: hoverkraft-tech/ci-github-common/actions/create-or-update-comment@0.4.3
- uses: hoverkraft-tech/ci-github-common/actions/create-or-update-comment@0.15.0
with:
title: "Images have been built :sparkles: !"
body: |
Expand Down
2 changes: 1 addition & 1 deletion images/ci-helm/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
ARG version=v3.12.0
FROM quay.io/helmpack/chart-testing:${version}

LABEL org.opencontainers.image.source = "https://github.com/hoverkraft-tech/docker-base-images"
LABEL org.opencontainers.image.source="https://github.com/hoverkraft-tech/docker-base-images"

# we can probably ignore warning about versions of such packages
# hadolint ignore=DL3018
Expand Down
2 changes: 1 addition & 1 deletion images/mydumper/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
FROM ubuntu:jammy

LABEL org.opencontainers.image.source = "https://github.com/hoverkraft-tech/docker-base-images"
LABEL org.opencontainers.image.source="https://github.com/hoverkraft-tech/docker-base-images"

ENV DEBIAN_FRONTEND=noninteractive \

Check warning on line 5 in images/mydumper/Dockerfile

View workflow job for this annotation

GitHub Actions / Continuous Integration / build-images / Build image mydumper for linux/amd64

Sensitive data should not be used in the ARG or ENV commands

SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ENV "MYSQL_PASSWORD") More info: https://docs.docker.com/go/dockerfile/rule/secrets-used-in-arg-or-env/

Check warning on line 5 in images/mydumper/Dockerfile

View workflow job for this annotation

GitHub Actions / Continuous Integration / build-images / Build image mydumper for linux/arm64

Sensitive data should not be used in the ARG or ENV commands

SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ENV "MYSQL_PASSWORD") More info: https://docs.docker.com/go/dockerfile/rule/secrets-used-in-arg-or-env/

Check warning on line 5 in images/mydumper/Dockerfile

View workflow job for this annotation

GitHub Actions / build-images / Build image mydumper for linux/amd64

Sensitive data should not be used in the ARG or ENV commands

SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ENV "MYSQL_PASSWORD") More info: https://docs.docker.com/go/dockerfile/rule/secrets-used-in-arg-or-env/

Check warning on line 5 in images/mydumper/Dockerfile

View workflow job for this annotation

GitHub Actions / build-images / Build image mydumper for linux/arm64

Sensitive data should not be used in the ARG or ENV commands

SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ENV "MYSQL_PASSWORD") More info: https://docs.docker.com/go/dockerfile/rule/secrets-used-in-arg-or-env/

Check warning on line 5 in images/mydumper/Dockerfile

View workflow job for this annotation

GitHub Actions / build-images / Build image mydumper for linux/arm/v7

Sensitive data should not be used in the ARG or ENV commands

SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ENV "MYSQL_PASSWORD") More info: https://docs.docker.com/go/dockerfile/rule/secrets-used-in-arg-or-env/
TZ=UTC \
Expand Down

0 comments on commit c43ab4f

Please sign in to comment.