Fix HEALPix unit conversion at load time #795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tskisner
approved these changes
Oct 28, 2024
There was a problem hiding this comment.
Thanks for fixing this!
In other places across the code, this helper function is used. Perhaps we could just fix that helper function and then use the function here?
|
Definitely! I just pushed an update and will merge once the unit tests pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an issue with HEALPix map unit conversion.
The units were being parsed correctly from the FITS header but somehow
scale.to(pix.units).valuewas always evaluating to1.0. Replacing it withscale.to_value(pix_units)did the trick.Many, many thanks to @tpsatt for reporting the problem!