Fix another place where unit conversion might have failed

src/toast/pixels_io_healpix.py

@@ -12,7 +12,7 @@
 from .io import have_hdf5_parallel
 from .mpi import MPI, use_mpi
 from .timing import Timer, function_timer
-from .utils import Logger, memreport
+from .utils import Logger, memreport, unit_conversion
 
 
 @function_timer
@@ -76,8 +76,7 @@ def read_healpix_fits(pix, path, nest=True, comm_bytes=10000000):
             log.info(msg)
             funits = pix.units
         if funits != pix.units:
-            scale = 1.0 * funits
-            fscale = scale.to_value(pix.units)
+            fscale = unit_conversion(funits, pix.units)
 
         if nside_map != nside:
             errors += f"Wrong NSide: {path} has {nside_map}, expected {nside}\n"

src/toast/utils.py

@@ -1,4 +1,4 @@
-# Copyright (c) 2015-2020 by the parties listed in the AUTHORS file.
+# Copyright (c) 2015-2024 by the parties listed in the AUTHORS file.
 # All rights reserved.  Use of this source code is governed by
 # a BSD-style license that can be found in the LICENSE file.
 
@@ -773,8 +773,7 @@ def unit_conversion(source, target):
 
     """
     scale = 1.0 * source
-    scale.to(target)
-    return scale.to(target).value
+    return scale.to_value(target)
 
 
 class SetDict(UserDict):