BC-8213 - validate room dates

src/modules/data/room/RoomCreate.state.ts

@@ -1,13 +1,11 @@
 import { RoomApiFactory, RoomColor } from "@/serverApi/v3";
-import { RoomCreateParams, RoomItem } from "@/types/room/Room";
+import { RoomApiError, RoomCreateParams, RoomItem } from "@/types/room/Room";
 import { $axios, mapAxiosErrorToResponseError } from "@/utils/api";
 import { createApplicationError } from "@/utils/create-application-error.factory";
-import { injectStrict, NOTIFIER_MODULE_KEY } from "@/utils/inject";
 import { ref } from "vue";
 import { useI18n } from "vue-i18n";
 
 export const useRoomCreateState = () => {
-	const notifierModule = injectStrict(NOTIFIER_MODULE_KEY);
 	const { t } = useI18n();
 
 	const roomApi = RoomApiFactory(undefined, "/v3", $axios);
@@ -20,9 +18,7 @@ export const useRoomCreateState = () => {
 		endDate: undefined,
 	});
 
-	const createRoom = async (
-		params: RoomCreateParams
-	): Promise<RoomItem | undefined> => {
+	const createRoom = async (params: RoomCreateParams): Promise<RoomItem> => {
 		isLoading.value = true;
 		try {
 			const room = (await roomApi.roomControllerCreateRoom(params)).data;
@@ -32,9 +28,10 @@ export const useRoomCreateState = () => {
 			const responseError = mapAxiosErrorToResponseError(error);
 
 			if (responseError.type === "API_VALIDATION_ERROR") {
-				notifierModule.show({
-					text: t("components.roomForm.validation.generalSaveError"),
-					status: "error",
+				throw new RoomApiError({
+					message: t("components.roomForm.validation.generalSaveError"),
+					type: responseError.type,
+					code: responseError.code,
 				});
 			} else {
 				throw createApplicationError(responseError.code);

src/modules/feature/room/RoomForm.unit.ts

@@ -26,7 +26,6 @@ const emptyMockRoom: RoomCreateParams = {
 describe("@feature-room/RoomForm", () => {
 	const setup = (props: ComponentProps<typeof RoomForm>) => {
 		const wrapper = mount(RoomForm, {
-			sync: false,
 			global: {
 				plugins: [createTestingVuetify(), createTestingI18n()],
 			},

src/modules/feature/room/RoomForm.vue

@@ -166,9 +166,9 @@ const onUpdateEndDate = (newDate: string) => {
 
 const onSave = async () => {
 	const valid = await v$.value.$validate();
-	if (valid) {
-		emit("save", roomData.value);
-	}
+	// if (valid) {
+	emit("save", roomData.value);
+	// }
 };
 
 const onCancel = async () => {

src/modules/page/room/RoomCreate.page.vue

@@ -10,15 +10,18 @@
 <script setup lang="ts">
 import { Breadcrumb } from "@/components/templates/default-wireframe.types";
 import DefaultWireframe from "@/components/templates/DefaultWireframe.vue";
-import { RoomCreateParams } from "@/types/room/Room";
+import { RoomApiError, RoomCreateParams } from "@/types/room/Room";
 import { buildPageTitle } from "@/utils/pageTitle";
 import { useRoomCreateState } from "@data-room";
 import { RoomForm } from "@feature-room";
 import { useTitle } from "@vueuse/core";
 import { computed } from "vue";
 import { useI18n } from "vue-i18n";
 import { useRouter } from "vue-router";
+import { createApplicationError } from "@/utils/create-application-error.factory";
+import { injectStrict, NOTIFIER_MODULE_KEY } from "@/utils/inject";
 
+const notifierModule = injectStrict(NOTIFIER_MODULE_KEY);
 const { t } = useI18n();
 
 const router = useRouter();
@@ -41,10 +44,19 @@ const breadcrumbs: Breadcrumb[] = [
 ];
 
 const onSave = async (roomParams: RoomCreateParams) => {
-	const room = await createRoom(roomParams);
+	try {
+		const room = await createRoom(roomParams);
 
-	if (room) {
 		router.push({ name: "room-details", params: { id: room.id } });
+	} catch (error) {
+		if (error instanceof RoomApiError) {
+			notifierModule.show({
+				text: t("components.roomForm.validation.generalSaveError"),
+				status: "error",
+			});
+		} else {
+			throw createApplicationError(400);
+		}
 	}
 };
 

src/types/room/Room.ts

@@ -12,3 +12,22 @@ export type RoomBoardItem = RoomBoardItemResponse;
 
 export type RoomCreateParams = CreateRoomBodyParams;
 export type RoomUpdateParams = UpdateRoomBodyParams;
+
+export class RoomApiError extends Error {
+	readonly type: string;
+	readonly code: number;
+
+	constructor({
+		message,
+		type,
+		code,
+	}: {
+		message: string;
+		type: string;
+		code: number;
+	}) {
+		super(message);
+		this.type = type;
+		this.code = code;
+	}
+}