Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-8213 - validate room dates #3434

Merged
merged 38 commits into from
Nov 27, 2024
Merged

Conversation

odalys-dataport
Copy link
Contributor

@odalys-dataport odalys-dataport commented Nov 1, 2024

Short Description

We want to make sure that only valid time periods for rooms are saved and are therefor adding validation that checks if the start date is before the end date.

Links to Ticket and related Pull-Requests

BC-8213
hpi-schul-cloud/schulcloud-server#5347

Changes

Data-security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Screenshot 2024-11-07 at 15 56 44 Screenshot 2024-11-12 at 13 39 32

Checklist before merging

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • PO: Any deviation from requirements was agreed with Product-Owner / ticket author / support-team
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please keep this Pull-Request as a Draft (or add WIP label), until it is ready to be reviewed

Copy link

sonarqubecloud bot commented Nov 7, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
69.5% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@odalys-dataport odalys-dataport self-assigned this Nov 7, 2024
@odalys-dataport odalys-dataport changed the title Bc 8213 validate room dates BC-8213 - validate room dates Nov 7, 2024
src/modules/data/room/RoomEdit.state.ts Outdated Show resolved Hide resolved
src/modules/feature/room/RoomForm.vue Outdated Show resolved Hide resolved
src/modules/feature/room/RoomForm.vue Outdated Show resolved Hide resolved
src/modules/feature/room/BoardGrid.unit.ts Outdated Show resolved Hide resolved
src/modules/feature/room/RoomDetails.unit.ts Show resolved Hide resolved
src/modules/feature/room/RoomForm.unit.ts Outdated Show resolved Hide resolved
src/modules/feature/room/RoomForm.unit.ts Show resolved Hide resolved
src/modules/data/room/RoomCreate.state.ts Outdated Show resolved Hide resolved
src/modules/page/room/RoomCreate.page.vue Show resolved Hide resolved
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
36.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@odalys-dataport odalys-dataport merged commit 7f5b75d into main Nov 27, 2024
68 of 69 checks passed
@odalys-dataport odalys-dataport deleted the BC-8213-validate-room-dates branch November 27, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants