Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BC-5829 - update mongoose for feathersjs 5 #3365

Merged
merged 3 commits into from
Dec 14, 2023
Merged

BC-5829 - update mongoose for feathersjs 5 #3365

merged 3 commits into from
Dec 14, 2023

Conversation

SevenWaysDP
Copy link
Contributor

@SevenWaysDP SevenWaysDP commented Dec 12, 2023 •
edited
Loading

Description

Links to Tickets or other pull requests

Changes

Data Security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Approval for review

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@SevenWaysDP SevenWaysDP mentioned this pull request Dec 12, 2023
Merged
3 tasks
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@SevenWaysDP SevenWaysDP enabled auto-merge (squash) December 14, 2023 15:56
@SevenWaysDP SevenWaysDP merged commit 6f0989d into main Dec 14, 2023
41 of 42 checks passed
@SevenWaysDP SevenWaysDP deleted the BC-5829-update-mongoose branch December 14, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CeEv CeEv CeEv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SevenWaysDP @CeEv