Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-5829 - update mongoose for feathersjs 5 #4573

Merged
merged 48 commits into from
Dec 14, 2023
Merged

Conversation

SevenWaysDP
Copy link
Contributor

@SevenWaysDP SevenWaysDP commented Nov 23, 2023

Description

Links to Tickets or other pull requests

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@SevenWaysDP SevenWaysDP changed the base branch from main to BC-5828-feathers-update November 23, 2023 09:37
@SevenWaysDP SevenWaysDP changed the base branch from BC-5828-feathers-update to main December 1, 2023 11:45
@SevenWaysDP SevenWaysDP changed the base branch from main to BC-5828-feathers-update December 1, 2023 11:58
src/utils/database.js Outdated Show resolved Hide resolved
Base automatically changed from BC-5828-feathers-update to main December 6, 2023 11:59
exports.ERROR = ERROR;

exports.errorHandler = (error) => {
if (error.code === 11000 || error.code === 11001) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aren't those the mongodb duplicate key error codes?

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@SevenWaysDP SevenWaysDP merged commit ba96d9e into main Dec 14, 2023
46 of 47 checks passed
@SevenWaysDP SevenWaysDP deleted the BC-5829-update-mongoose branch December 14, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants