Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-6842 - Adjust design system #3432

Merged
merged 5 commits into from
Apr 10, 2024
Merged

Conversation

NFriedo
Copy link
Contributor

@NFriedo NFriedo commented Mar 27, 2024

Description

Adjust system in order to create a uniform design system according to Material Design principles. Due to changes in the vue client we also want to adjust some colors in the legacy client.

Links to Tickets or other pull requests

BC-6842
Vue Client: hpi-schul-cloud/nuxt-client#3170

Changes

  • adjust secondary colors for themes
  • adjust gray-dark color for themes

Data Security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Approval for review

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@hoeppner-dataport hoeppner-dataport merged commit 9f1230d into main Apr 10, 2024
46 of 47 checks passed
@hoeppner-dataport hoeppner-dataport deleted the BC-6842-adjust-design-system branch April 10, 2024 07:17
bergatco pushed a commit that referenced this pull request Apr 10, 2024
* exchange color from 54616E to 3a424b
* adjust secondary color, add different gray dark colors for themes

---------

Co-authored-by: Ramona Weitzenberg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants