Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-6460 Remove redis-node package #3435

Merged
merged 5 commits into from
Apr 8, 2024
Merged

Conversation

blazejpass
Copy link
Contributor

@blazejpass blazejpass commented Apr 3, 2024

Description

QA note:
Change tested on env :
https://bc-6460-one-redis-library.nbc.dbildungscloud.dev/
No issues found. Tests were made in general to check basic functionality of system like creating courses plus content, team, homework, adding accounts, learning store , help section , management.

As ioredis library was introduced to project, there was a need to remove redis (redis-node) library

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/BC-6460
hpi-schul-cloud/schulcloud-server#4890

Changes

Data Security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Approval for review

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

Copy link

sonarqubecloud bot commented Apr 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@blazejpass blazejpass merged commit 6e93c59 into main Apr 8, 2024
46 of 49 checks passed
@blazejpass blazejpass deleted the BC-6460-one-redis-library branch April 8, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants