Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-6460 Remove redis-node package #4890

Merged
merged 16 commits into from
Apr 8, 2024
Merged

Conversation

blazejpass
Copy link
Contributor

@blazejpass blazejpass commented Apr 3, 2024

Description

As ioredis library was introduced to project, there was a need to remove redis (redis-node) library

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/BC-6460
hpi-schul-cloud/schulcloud-client#3435

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@blazejpass blazejpass added the WIP This feature branch is in progress, do not merge into master. label Apr 4, 2024
@blazejpass blazejpass added waiting for review and removed WIP This feature branch is in progress, do not merge into master. labels Apr 4, 2024
Copy link

sonarqubecloud bot commented Apr 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@blazejpass blazejpass merged commit 61f6380 into main Apr 8, 2024
55 of 56 checks passed
@blazejpass blazejpass deleted the BC-6460-one-redis-library branch April 8, 2024 12:14
bergatco pushed a commit that referenced this pull request May 6, 2024
* Remove redis-node package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants