Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-7700 BC-7701 BC-7702 - replacing LC links on platform #3499

Merged
merged 4 commits into from
Aug 6, 2024

Conversation

MartinSchuhmacher
Copy link
Contributor

@MartinSchuhmacher MartinSchuhmacher commented Aug 5, 2024

Description

Changing the location of the video training material to a separate federal state location for each state.
For that a new env var TRAINING_URL is introduced.

  • editing ACCESSIBILITY_REPORT_EMAIL for dBC (currently not visible, just for keeping it up to date)

Links to Tickets or other pull requests

BC-7700
BC-7701
BC-7702

hpi-schul-cloud/dof_app_deploy#929
hpi-schul-cloud/schulcloud-server#5170
hpi-schul-cloud/nuxt-client#3350

Approval for review

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@MartinSchuhmacher MartinSchuhmacher self-assigned this Aug 5, 2024
@MartinSchuhmacher MartinSchuhmacher changed the title BC-7700 -BC-7701 - BC-7702 - replacing LC links on platform BC-7700 BC-7701 BC-7702 - replacing LC links on platform Aug 5, 2024
@@ -175,7 +175,7 @@
zusammen mit der <a
href="https://www.philso.uni-augsburg.de/lehrstuehle/schulpaed/Projekte/Digitalisierung/Lernen-4_0-in-der-Praxis/"
target="_blank">Universität Augsburg</a>
einen MOOC zu dem Thema <a href="https://lernen.cloud/" target="_blank">Lernen 4.0 -
einen MOOC zu dem Thema <a href="https://www.schulportal-thueringen.de/tio" target="_blank">Lernen 4.0 -
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could use TRAINING_URL here too, right? That way we'd only need to adjust the url in the config, if it changes

Copy link

sonarqubecloud bot commented Aug 6, 2024

@MartinSchuhmacher MartinSchuhmacher merged commit 90d0106 into main Aug 6, 2024
46 checks passed
@MartinSchuhmacher MartinSchuhmacher deleted the BC-7700-replace-lc-links branch August 6, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants