Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-7700 BC-7701 BC-7702 - replacing LC links on platform #5170

Merged
merged 4 commits into from
Aug 6, 2024

Conversation

MartinSchuhmacher
Copy link
Contributor

@MartinSchuhmacher MartinSchuhmacher commented Aug 5, 2024

Description

Changing the location of the video training material to a separate federal state location for each state.
For that a new env var TRAINING_URL is introduced.

  • editing ACCESSIBILITY_REPORT_EMAIL for dBC (currently not visible, just for keeping it up to date)

Links to Tickets or other pull requests

BC-7700
BC-7701
BC-7702

hpi-schul-cloud/schulcloud-client#3499
hpi-schul-cloud/dof_app_deploy#929
hpi-schul-cloud/nuxt-client#3350

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@@ -89,5 +89,6 @@
"BOARD_COLLABORATION_URI": "ws://localhost:4450",
"ADMIN_API": {
"ALLOWED_API_KEYS": "thisisasupersecureapikeythatisabsolutelysave"
}
},
"TRAINING_URL": "https://lernen.dbildungscloud.de"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not needed because of default value exists, but it's good to have it for more transparency 👍

Copy link

sonarqubecloud bot commented Aug 6, 2024

@MartinSchuhmacher MartinSchuhmacher merged commit 622e80e into main Aug 6, 2024
55 checks passed
@MartinSchuhmacher MartinSchuhmacher deleted the BC-7700-replace-lc-links branch August 6, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants