Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-8213 - validate room dates #5347

Merged
merged 4 commits into from
Nov 29, 2024
Merged

Conversation

MartinSchuhmacher
Copy link
Contributor

@MartinSchuhmacher MartinSchuhmacher commented Nov 19, 2024

Description

We want to make sure that only valid time periods for rooms are saved and are therefor adding validation that checks if the start date is before the end date.

Links to Tickets or other pull requests

BC-8213
hpi-schul-cloud/nuxt-client#3434

Changes

  • move validation from DO to room service

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@MartinSchuhmacher MartinSchuhmacher enabled auto-merge (squash) November 29, 2024 09:13
@MartinSchuhmacher MartinSchuhmacher merged commit 6c1cf2e into main Nov 29, 2024
77 checks passed
@MartinSchuhmacher MartinSchuhmacher deleted the BC-8213-validate-room-dates branch November 29, 2024 09:20
HKayed pushed a commit that referenced this pull request Nov 29, 2024
* fixing room date validation on create and update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants