Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support multiple backend configurations #2

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ziwiwiz
Copy link

@ziwiwiz ziwiwiz commented Feb 27, 2025

feat: support multiple backend configurations

@hsuyelin
Copy link
Owner

hsuyelin commented Mar 6, 2025

Thanks for your PR! This contribution is really meaningful. When I wrote the code earlier, I only considered my current needs and didn’t account for multiple backends. I’ve reviewed your code, and it looks good overall. Just wanted to check—have you tested it locally? Here are some test cases I’ve been thinking about:

  1. Single backend: Configure the backend path and address correctly and check if it redirects properly. Expected result: It should successfully redirect to the specified backend and play.

  2. Single backend: Configure an incorrect backend path and address that do not match the backend settings in the config file. Expected result: It should fail to match and print an error.

  3. Multiple backends: Configure the backend path and address correctly and check if it redirects properly. Expected result: It should successfully redirect to the specified backend and play.

  4. Multiple backends: Mix correct and incorrect backend paths and addresses. Check if the correctly configured backends can play properly (expected: they should play). Check if the incorrectly configured backends can play properly (expected: they should not play, and a log should be printed).

If you’ve already tested these cases, I’ll go ahead and merge the code into the main branch. This is really exciting—I’m looking forward to your reply!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants