Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

French Translation Wave #2 :) #240

Merged
merged 44 commits into from
Dec 28, 2023
Merged

French Translation Wave #2 :) #240

merged 44 commits into from
Dec 28, 2023

Conversation

niltied
Copy link
Contributor

@niltied niltied commented Dec 10, 2023

Hi @hossainemruz,

I took some time to continue my French translation and perfect it. After the 1st MR was published, I saw things that weren't perfect. For example, at the root of the documentation in the French version, the left menu was not fully translated. There is still English.

I propose to you this new MR with the following improvements :

  • Improved french translation on the first translated pages.
  • Improved too of front matter on the first translated pages.
  • A lot of fix to markdown syntax on the first translated pages (thank Markdown All in One plugins for VScode).
  • Finished to provide full french translation about "deploy site in Netlify" page.
  • Provide initial full french translation of comment page in root doc.
  • Provide initial full french translation of enable dark theme in customize category.

I provide too a few index.for.md for Getting-started category and Customize category but I'm not sure of effects for the hierarchical menu on the left. I haven't tested.

@hossainemruz
Copy link
Member

Thank you @niltied. Can you please resolve the conflicts? Please rebase your PR against the upstream.

@niltied
Copy link
Contributor Author

niltied commented Dec 16, 2023

Hello @hossainemruz,

So, conflicts are resolved. But I have another problem : when you browse on the preview, and select French language, on the left menu, "démarre" appears twice and "personnalisation" too. I don't understand how resolv it with markdown hierarchy file. I have translate _index.md to _index.fr.md for example, but it seem that doesn't work. An advice ?

Arf... I saw too that "Support Link" title isn't translate on the Front Matter of markdown file. I resolve that next time.

Copy link
Member

@hossainemruz hossainemruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for resolving the conflicts. I have pointed out the possible issues in the comments that can cause duplicate entry in the left sidebar.

content/posts/getting-started/prepare-site/index.fr.md Outdated Show resolved Hide resolved
content/posts/getting-started/netlify/index.fr.md Outdated Show resolved Hide resolved
content/posts/getting-started/github-pages/index.fr.md Outdated Show resolved Hide resolved
content/posts/customizing/dark-theme/index.fr.md Outdated Show resolved Hide resolved
Rollback Parent: variable
Rollback parent: variable
Rollback parent: variable
Rollback on parent: variable
Copy link
Contributor Author

@niltied niltied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review done

content/posts/getting-started/github-pages/index.fr.md Outdated Show resolved Hide resolved
content/posts/getting-started/prepare-site/index.fr.md Outdated Show resolved Hide resolved
Copy link
Member

@hossainemruz hossainemruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @niltied. Looks good. Just one last adjustment is necessary. Please, use your name as author and provide your image in the translated posts.

content/posts/customizing/dark-theme/index.fr.md Outdated Show resolved Hide resolved
content/posts/getting-started/github-pages/index.fr.md Outdated Show resolved Hide resolved
fix to lowercase 'getting-started' (parent: variable) in front-matter
Change author name and avatar for the french version
Add avatar of niltied
Fix sidebar french title
@niltied
Copy link
Contributor Author

niltied commented Dec 28, 2023

@hossainemruz,

I have completed all the corrections. Now, the preview of the documentation in its French version is correct.

The left menu is finally correctly translated and organized. You can merge whenever you want. I will be able to prepare the rest on my side. See you :)

Copy link
Member

@hossainemruz hossainemruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @niltied! LGTM 🚀

@hossainemruz hossainemruz merged commit 3c51f59 into hugo-toha:main Dec 28, 2023
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants