-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
French Translation Wave #2 :) #240
Conversation
Thank you @niltied. Can you please resolve the conflicts? Please rebase your PR against the upstream. |
Hello @hossainemruz, So, conflicts are resolved. But I have another problem : when you browse on the preview, and select French language, on the left menu, "démarre" appears twice and "personnalisation" too. I don't understand how resolv it with markdown hierarchy file. I have translate _index.md to _index.fr.md for example, but it seem that doesn't work. An advice ? Arf... I saw too that "Support Link" title isn't translate on the Front Matter of markdown file. I resolve that next time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for resolving the conflicts. I have pointed out the possible issues in the comments that can cause duplicate entry in the left sidebar.
Rollback Parent: variable
Rollback parent: variable
Rollback parent: variable
Minor fix
Rollback on parent: variable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @niltied. Looks good. Just one last adjustment is necessary. Please, use your name as author and provide your image in the translated posts.
fix to lowercase 'getting-started' (parent: variable) in front-matter
Change author name and avatar for the french version
Add avatar of niltied
Fix sidebar french title
I have completed all the corrections. Now, the preview of the documentation in its French version is correct. The left menu is finally correctly translated and organized. You can merge whenever you want. I will be able to prepare the rest on my side. See you :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @niltied! LGTM 🚀
Hi @hossainemruz,
I took some time to continue my French translation and perfect it. After the 1st MR was published, I saw things that weren't perfect. For example, at the root of the documentation in the French version, the left menu was not fully translated. There is still English.
I propose to you this new MR with the following improvements :
I provide too a few index.for.md for Getting-started category and Customize category but I'm not sure of effects for the hierarchical menu on the left. I haven't tested.