Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial translation/update french guides and add fixes #274

Merged
merged 53 commits into from
Feb 23, 2024

Conversation

niltied
Copy link
Contributor

@niltied niltied commented Feb 4, 2024

Hi @hossainemruz,

This PR from my main branch contain :

  • Several new guides translated in french (mainly category Customizing et Translation )
  • Add several fixes everywhere

Please, take the time to check all. Because, I'm not a champion with git. I still learn, and it's not easy for me.
The french documentation will be completed soon like English and Spanish. I think I translated almost everything.

@hossainemruz
Copy link
Member

Thank you @niltied! Can you please, rebase your PR and fix the build?

@hossainemruz
Copy link
Member

The build failure was due to incorrect image extension. Fixed it now.

Copy link
Member

@hossainemruz hossainemruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @niltied

@hossainemruz hossainemruz merged commit 0d60bc8 into hugo-toha:main Feb 23, 2024
3 of 5 checks passed
@niltied
Copy link
Contributor Author

niltied commented Feb 23, 2024

Hi Emruz,

I'm sorry, I've been really busy lately, that's why I haven't been around as much lately. Thank U for your fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants