Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add log data for benchmarking #127

Merged
merged 4 commits into from
Nov 19, 2024

Conversation

KevRiver
Copy link
Contributor

No description provided.

@KevRiver
Copy link
Contributor Author

@aybabtme
golangci-lint on Windows fails with timeout while loading go/packages.
IMO, we can try to pass the cmd line argument --timeout N(as shown in error message) to golangci-lint so that its package load time could be ensured.

Running [D:\a\_temp\3e304b95-f6d4-4d10-92d4-4b129990b036\golangci-lint-1.60.3-windows-amd64\golangci-lint run  --fast] in [D:\a\humanlog\humanlog] ...
  level=error msg="Running error: context loading failed: failed to load packages: failed to load packages: failed to load with go/packages: err: context deadline exceeded: stderr: "
  level=error msg="Timeout exceeded: try increasing it by passing --timeout option"

@aybabtme
Copy link
Collaborator

aybabtme commented Nov 17, 2024

@KevRiver if you rebase, you'll pick up this change a054e07

@KevRiver KevRiver force-pushed the add-structured-log-data branch from d8b0c36 to 7821284 Compare November 18, 2024 06:25
@aybabtme
Copy link
Collaborator

My mistake, the timeout indeed needs to be lengthened. This is quite annoying, sorry.

@aybabtme aybabtme merged commit 6f62d39 into humanlogio:master Nov 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants